doc/ko: Add missing options in uftrace-record.md #1956

KyeongTaek · 2024-09-02T11:45:08Z

The missing option '--trace=STATE' is translated and added to uftrace-record.md in Korean.

MichelleJin12 · 2024-09-02T12:15:45Z

Thank you for contributing @KyeongTaek

Could you add other missing options in uftrace-record.md?
like

Lines 226 to 229 in 9d88589

    
           -g, \--agent 
        
           :   Spawn an agent thread in the target.  At runtime, the agent receives 
        
               external commands and can change supported tracing options.  See *AGENT* 
        
               section in the `uftrace-live`(1).

doc/ko/uftrace-record.md

ntw8651 · 2024-09-08T06:42:30Z

I think that It is a good contribution @KyeongTaek
Could you add other things in uftrace-record.md?

uftrace/doc/uftrace-record.md

Lines 243 to 245 in 9d88589

    
           These filters can be applied either at record time or replay time.  They can be 
        
           added and removed at runtime from the client.  See `uftrace-live`(1) for details 
        
           about agent operations.

"They can -..."
and this

uftrace/doc/uftrace-record.md

Line 892 in 9d88589

* "var": read value of a global variable given after ":".

uftrace/doc/uftrace-record.md

Lines 909 to 922 in 9d88589

    
           This is how to use 'var' watchpoints: 
        
                $ uftrace -W var:mydata a.out 
        
                # DURATION     TID     FUNCTION 
        
                            [239842] | __monstartup() { 
        
                            [239842] |   /* watch:var (mydata=7) */ 
        
                   3.534 us [239842] | } /* __monstartup */ 
        
                   0.191 us [239842] | __cxa_atexit(); 
        
                            [239842] | main() { 
        
                            [239842] |   foo() { 
        
                            [239842] |     /* watch:var (mydata=42) */ 
        
                   0.381 us [239842] |     bar(); 
        
                   1.069 us [239842] |   } /* foo */ 
        
                   2.698 us [239842] | } /* main */

thank you.

The missing option '--trace=STATE' is translated and added to uftrace-record.md in Korean. The missing option '-g, \--agent' is translated and added to uftrace-record.md in Korean corrected some translations added missing description for filter add 'var' watchpoint and its usage Signed-off-by: KyeongTaek <[email protected]>

namhyung

LGTM

namhyung reviewed Sep 4, 2024

View reviewed changes

doc/ko/uftrace-record.md Outdated Show resolved Hide resolved

doc/ko/uftrace-record.md Outdated Show resolved Hide resolved

KyeongTaek force-pushed the master branch from 8f1e3c8 to 09d026b Compare September 4, 2024 09:09

KyeongTaek force-pushed the master branch from 09d026b to e865eb4 Compare September 14, 2024 15:25

KyeongTaek force-pushed the master branch from e865eb4 to 5c2d00c Compare September 14, 2024 15:33

namhyung approved these changes Sep 15, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

doc/ko: Add missing options in uftrace-record.md #1956

doc/ko: Add missing options in uftrace-record.md #1956

KyeongTaek commented Sep 2, 2024

MichelleJin12 commented Sep 2, 2024

ntw8651 commented Sep 8, 2024

namhyung left a comment

doc/ko: Add missing options in uftrace-record.md #1956

Are you sure you want to change the base?

doc/ko: Add missing options in uftrace-record.md #1956

Conversation

KyeongTaek commented Sep 2, 2024

MichelleJin12 commented Sep 2, 2024

ntw8651 commented Sep 8, 2024

namhyung left a comment

Choose a reason for hiding this comment